search

Insubstantial / insubstantial

Swing look-and-feel library and assorted widgets
193 stars 57 forks source link

JRibbonFrame does not dispose of app icon thread properly #73

Closed flynnk closed 12 years ago

flynnk commented 12 years ago

This commit:

https://github.com/Insubstantial/insubstantial/commit/ef08fb2befadcd7edccb57b02d03e95f80f28924

introduces a new thread that is not daemon and not shutdown when the ribbonframe is disposed. This means that the JRIbbonFrame class blocks the proper Swing UI shutdown when all windows are disposed.

Fix is to call:

((ExecutorService) setAppIconExecutor).shutdownNow();

in dispose().

Workaround (since that executor is protected) is to shut it down manually when the window is closing.