search

Intechnity-com / OdooJsonRpcClient

Odoo Client Json Rpc
MIT License
67 stars 29 forks source link

Avoid duplicated .NET names in model generation (Fix #50) #62

Open manitra opened 1 year ago

manitra commented 1 year ago

A better approch to solving issue #50 is just to create a naming container and add an auto incremented suffix in case of duplicates. This way, we don't have to do the "+" and "-" hacks in the naming construction.

I took the opportunity to separate the Nullability question to a separate method as well because the rules are not that trivial.

This PR is a better alternative to #59 and I'm going to close #59 .

patricoos commented 1 year ago

this is a very big change, please add some tests here

manitra commented 1 year ago

Indeed. I’ll add tests later this week.

Le lun. 27 mars 2023 à 11:32, Patrick @.***> a écrit :

this is a very big change, please add some tests here

— Reply to this email directly, view it on GitHub https://github.com/patricoos/PortaCapena.OdooJsonRpcClient/pull/62#issuecomment-1484728075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMT6TF4CHTJU4EPUJU3AEDW6FGCTANCNFSM6AAAAAAWHOHFZ4 . You are receiving this because you authored the thread.Message ID: @.***>