search

IntegralEnvision / integral

Package for Integral functions
https://integralenvision.github.io/integral/
Other
0 stars 0 forks source link

Add new_proj #8

Closed ebenp closed 2 years ago

ebenp commented 2 years ago

Added a create_project function. Please test locally, locally in the office, on Citrix remotely and in the office and on Linux.

Including @jzadra

ebenp commented 2 years ago

Should probably refactor this into separate functions and merge with the existing file create functions before merge.

ebenp commented 2 years ago

@jzadra This is ready for your review

ebenp commented 2 years ago

Hidden files in inst are not copied (.gitignore). Will have to decide on a name to copy them across

ebenp commented 2 years ago

Fixed .gitignore copy issues Should add copy failure for folder warnings

ebenp commented 2 years ago

Some oddness with overwriting Rproj files

kheal commented 2 years ago

I tested ic_new_proj() locally and on Linux box, works great. I thought we decided to make the default NOT make an renv during this. I'd like that default to change.

integral::ic_news() throws this: there is no package called ‘commonmark’.

integral::ic_new_python_file(), integral::ic_new_r_file(). I suggest changing the Purpose: and History sections of the template to empty or more generalized (similar to what is called in the ic_new_rmd_file(). If not, we're going to end up with 1000 scripts with the same purpose.

integral::ic_new_rmd_file(), I suggest forgoing an output default. I think folks who will use .rmd should be able to set their own outputs.

ebenp commented 2 years ago

Thanks! These are great suggestions. I'll integrate them in. Eben

Eben Pendleton (he/him/his) | Project Scientist Tel: 207.800.3808 45 Exchange Street, Suite 200 | Portland | ME 04101 @.*** | www.integral-corp.com

[cid:integral-logo_bb8ba854-3124-462b-8a66-06670ee4325c.jpg] From: Katherine Heal @.> Sent: Tuesday, June 14, 2022 4:23 PM To: IntegralEnvision/integral-private @.> Cc: Eben Pendleton @.>; Author @.> Subject: Re: [IntegralEnvision/integral-private] Add new_proj (PR #8)

[CAUTION: External email. Think before you click links or open attachments.]

I tested ic_new_proj() locally and on Linux box, works great. I thought we decided to make the default NOT make an renv during this. I'd like that default to change.

integral::ic_news() throws this: there is no package called ‘commonmark’.

integral::ic_new_python_file(), integral::ic_new_r_file(). I suggest changing the Purpose: and History sections of the template to empty or more generalized (similar to what is called in the ic_new_rmd_file(). If not, we're going to end up with 1000 scripts with the same purpose.

integral::ic_new_rmd_file(), I suggest forgoing an output default. I think folks who will use .rmd should be able to set their own outputs.

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_IntegralEnvision_integral-2Dprivate_pull_8-23issuecomment-2D1155676233&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=gSHwxelS22ZqidOSMsNwtQmM0boS6SXeFon3b8F1mQY&m=5TwEmFt2G9t4WtOw8aIr6ITPF9zF_0pSEOIJDB4h5A4&s=yA89hQix3WS8nQJJIB7wc3nG2OJzNXkqzBmNsyRoLhY&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AA7EDMYJZL6OGMFF2IDABCTVPDS3VANCNFSM5VRZM5JQ&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=gSHwxelS22ZqidOSMsNwtQmM0boS6SXeFon3b8F1mQY&m=5TwEmFt2G9t4WtOw8aIr6ITPF9zF_0pSEOIJDB4h5A4&s=pRdplpc84A3k-qoMOFuNBVM-psyBOq5yg1d648zXi6E&e=. You are receiving this because you authored the thread.Message ID: @.**@.>>

ebenp commented 2 years ago

Updated templates and couldn't recreate ic_news error locally.