codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 0% with 65 lines in your changes are missing coverage. Please review.
Project coverage is 51.98%. Comparing base (
eb03b21) to head (091a86f).
| Files | Patch % | Lines |
|---|---|---|
| ext/IntiMeshesExt.jl | 0.00% | 43 Missing :warning: |
| src/reference_interpolation.jl | 0.00% | 13 Missing :warning: |
| src/mesh.jl | 0.00% | 6 Missing :warning: |
| ext/IntiGmshExt.jl | 0.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== - Coverage 53.52% 51.98% -1.54% ========================================== Files 19 20 +1 Lines 1930 1987 +57 ========================================== Hits 1033 1033 - Misses 897 954 +57 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR introduces a Meshes.jl extension for visualization purposes. The extension contains essentially two functions:
to_meshes: takes anIntiobject, and return the equivalent object inMeshesviz(and the inplaceviz!): trigger a Makie recipe, powered byMeshes`Overall, I found this approach easier than directly creating and tweaking
Makierecipes.Some other collateral changes:
GLMakieinstead ofCairoMakiefor the documentation (nicer rendering IMO, specially for 3d)CIso that we can useGLMakie.ipynbon theCIto speed things up. The.mdfiles are executed anyways duringDocumenter's build process, so the main errors that could exist in the.ipynbare related to the environment setup. Still we may want to bring these tests back in the future.connectivityto facilitate the conversion to theSimpleMeshinMeshes.jlSince this is an extension, I think we can go ahead and merge this quickly, field test it, and improve on it as we go.