IntegratedAlarmSystem-Group / ias-display

IAS Display, implemented in Angular
Other
1 stars 1 forks source link

Pass alarm dependencies AND configuration children to Antenna details table #116

Closed sfehlandt closed 5 years ago

sfehlandt commented 5 years ago

Oriignally, we passed the children of the antennas configurations to the Table in each Antenna detail view. See #107.

Then we changed it to passe the Antenna's dependencies instead of the children of the configurations. See #115.

The upside of this new approach is that we no longer need the children configurations, which are indeed verbose and complex to maintain. The downside on the other hand, is that if one of the dependencies does not arrive to the Core the general alarm of the antenna is not published (due to design decisions in the Ias Core), and hence, we don't have the dependencies to fil the Table, which remains empty.

In order to fix that, we should "merge" both behaviours: get the alarms from the merge of the alarm-dependencies and config-children.