IntegratedAlarmSystem-Group / ias-display

IAS Display, implemented in Angular
Other
1 stars 1 forks source link

Add props (map that contains the value) of last update to the Table #98

Closed sfehlandt closed 5 years ago

acaproni commented 5 years ago

What does this ticket mean? Is it the value of associated IASIOs that triggered the alarm like for instance the value of a temperature sensor that triggered a temperature alarm? If it is that then this ticket must be more generic and be something like let the table show the additional information of alarms Additional information are passed as a map whose content depends on the implementation of reduction rules and no assumption can be done on its content (Keys) in the web application.

Additional info should be shown in all the panels, not only in the table. A tooltip coul dbe enough otside of thetable.

sfehlandt commented 5 years ago

We could show all the "props" in the ack / shelve panels. But for the tooltip and table it could be too much. Can't we agree that if the map contains the value it will be in the key "value"? this way we can show it if the key "value" is in the map "props" of the IASIO. Otherwise we don't show it. In any case, the props will still be available in the Ack / Shelve panel.

Btw, I was just reviewing the IASIOS in the kafka queue and only weather alarms have "props". SOme of them have a key "value" with the value, but some of them have the key "backup" with a value. Is it that when the value comes from a primary WS the key is "value", whereas the key is "backup" when the value comes from a backup WS? if that is the case, and since you want to show that map directly to operators maybe we should change that to 2 or 3 keys, for example: {value: 110.5, ws: Meteo130, type_of_ws: backup }

acaproni commented 5 years ago

I agree to show all the props in the ACK and shelve. For the tooltip we could show only one or two props and allow the operator to see all of them by selecting the tooltip (to be double checked with Grazia for usability/readability).

Your proposal works for just one value but not if there are many values. The ThresholdWithBackupsAndDelay TF sets the key value with the value read from the main WS if it exists; otherwise it returns the key backupwith the comma separated values of the backups weather stations. With this definition, only one between value and backup is defined.

sfehlandt commented 5 years ago

We talked on a videocon and we decided this:

sfehlandt commented 5 years ago

I will update the issues accordingly