search

Intel-Media-SDK / MediaSDK

The Intel® Media SDK
MIT License
938 stars 460 forks source link

allow ROI rectangle top/left/bottom/right to be 0 for query #2013

Open guoyejun opened 4 years ago

guoyejun commented 4 years ago

i submitted a PR https://github.com/Intel-Media-SDK/MediaSDK/pull/1856 for this issue, and after discussion, i hoped to pass the ball back to msdk team.

I just checked the latest code and found that we still need to set a non-empty rectangle for the query, so file this issue to check it. Hope it can be resolved before next release, thanks.

guoyejun commented 4 years ago

any update? thanks.

guoyejun commented 4 years ago

any update? thanks

daleksan commented 4 years ago

@vilichev please follow up

vilichev commented 4 years ago

@yskuridi Please investigate

yskuridi commented 4 years ago

proposed a solution. waiting for confirmation from architects

dmitryermilov commented 4 years ago

Dear @guoyejun ,

Sorry for delay. We're discussed internally. The plan is the following: Per the msdk manual, Query shall return max number of supported ROI if app passes 256 to input params: NumROI - Number of ROI descriptions in array. The Query function mode 2 returns maximum supported value (set it to 256 and Query will update it to maximum supported value).

But currently AVC and HEVC encoders treats zero size rect's as error. We'll fix it. Query will fill rect sizes with min supported sizes.

@yskuridi , could you implement a fix?

dmitryermilov commented 4 years ago

Commit above fixes HEVC. We need to fix AVC as well. So re-opening