Intel-Media-SDK / MediaSDK

The Intel® Media SDK
MIT License
926 stars 457 forks source link

Ignore av1 reserved units #2965

Open zhangyichix opened 2 years ago

zhangyichix commented 2 years ago

Some av1 videos may contain reserved units. We should ignore it instead of returning an error.

Reference source: https://aomediacodec.github.io/av1-spec/av1-spec.pdf Section 6.2.2: Reserved units are for future use and shall be ignored by AV1 decoder.

wangyan-intel commented 2 years ago

Could you please share what issue is hit if no this fix? Thanks.

zhangyichix commented 2 years ago

The issue I found while doing android cts. Some test videos contains reserved obu type, and the MSDK returned UMC::UMC_ERR_NOT_IMPLEMENTED. According to the av1-spec, we should ignore it and continue to process.

wangyan-intel commented 2 years ago

@zhangyichix I cannot find section 6.2.6 from your spec URL. Do you mean section 6.3? @ChunjuanLiu Could you please review it?

zhangyichix commented 2 years ago

@wangyan-intel sorry, it is 6.2.2. OBU header semantics.