search

Intel-bigdata / HiBench

HiBench is a big data benchmark suite.
Other
1.46k stars 765 forks source link

set tolerance to 0 #651

Closed minmingzhu closed 3 years ago

minmingzhu commented 3 years ago

Signed-off-by: minmingz minming.zhu@inte.com

xwu99 commented 3 years ago

@minmingzhu there is a convergedist param in kmeans.conf, I think it's not used anywhere and may cause confusion, could you consider to remove it ?

xwu99 commented 3 years ago

Signed-off-by: minmingz minming.zhu@inte.com

You may consider to add a code comment to explain why you set tolerance to 0.

minmingzhu commented 3 years ago

@minmingzhu there is a convergedist param in kmeans.conf, I think it's not used anywhere and may cause confusion, could you consider to remove it ?

Yes, I check it that convergedist was not used anywhere. It has been removed.

minmingzhu commented 3 years ago

Signed-off-by: minmingz minming.zhu@inte.com

You may consider to add a code comment to explain why you set tolerance to 0.

it's done.