search

Intel-bigdata / SSM

Smart Storage Management for Big Data, a comprehensive hot/cold data optimized solution
Apache License 2.0
134 stars 67 forks source link

Modify kerberos deployment settings and add auto-test scripts #2131

Closed lipppppp closed 4 years ago

lipppppp commented 4 years ago

The kerberos deployment document exist some problems.

  1. New principal should have correct permission to execute actions on HDFS when set the smartsever and smartagent principal. 2.The smart-site.xml should be updated on each agent node.

By the way, I add some test scripts of hdp3 hadoop.

PHILO-HE commented 4 years ago

Thanks @lipppppp for your contribution. I have some suggestions.

  1. Could you please divide the patch into two? One for updating keberos deployment doc and the other for adding test scripts, using two pull requests. Generally, one commit patch should be as least as possible.
  2. The folder named ambari-test looks ambiguous to user, you can use other name, like performance-test.
  3. There are several source code files that has no changes, but included in the PR, like supports/ec-performance-test/config. It is better to excude them.
  4. There is no code in supports/ambari-test/ec-test/_init_.py, so please exclude it.
  5. You may unintentionally delete supports/compression-test/SSM Compression Test Plan.md. We can just keep it in the repo. Please use git diff (for not added change) or git diff --cached (for not commited change) or git show (for committed change) to check the code changes.
  6. In _supports/integration-test/resetenv.py, you are proposing to change the mapreduce jar path. It seems that the original path is correct, i.e., under _$HADOOPHOME/share for many versions of Hadoop. Please double check the path.
lipppppp commented 4 years ago

Thanks for your suggestions. I will close this request and divide this patch into two.