search

Intel-bigdata / SSM

Smart Storage Management for Big Data, a comprehensive hot/cold data optimized solution
Apache License 2.0
133 stars 67 forks source link

Display 'add rule&run action' exception info to web #2196

Closed MajorJason closed 3 years ago

MajorJason commented 3 years ago

When user run action in submit stage or add rule, the exception won't display in the web. So we add exception displaying part to give users more clear exception information.

PHILO-HE commented 3 years ago

@MajorJason, thanks for your contribution. For displaying exception, could you leave a screenshot here? Thus, I can see the effect with this patch.

lipppppp commented 3 years ago

For example , wrong action name won't displaying exception. image After this patch, the exception message part will display. image

PHILO-HE commented 3 years ago

I see. The patch looks good to me. I will commit it soon. Thanks for your awesome work!

PHILO-HE commented 3 years ago

By the way, @lipppppp, after double think about checking legality of rule/action, I would like to give the following suggestion. If tasks are generally submitted from front end, I think you can just do the check at front end, which may avoid most issues already. But, if some tasks are submitted through script and bypassing front end in real environment, you may need to do the check at back end.

lipppppp commented 3 years ago

Good suggestion, we will add the check at back end to improve this.