Closed dxoigmn closed 1 year ago
Do you have a plan for modality-aware?
Nope.
I have made a shared modality-batch-aware mechanism in #115 for Initializer, Projector and Composer.
I have made a shared modality-batch-aware mechanism in #115 for Initializer, Projector and Composer.
Okay. Is the idea that this PR should be updated to use that? I also saw there was an opportunity to DRY the logic but wanted to wait until after we get everything merged. I'll try to read through what you wrote though.
@mzweilin: I think it's better to merge this now than wait for the generic dispatch to be done since it updates the tests to conform to the existing interface.
What does this PR do?
The current
Projector
is not batch/tuple aware, which is necessary for attacks on datasets where input images have different shapes (e.g., COCO). This PR makes it so.Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
make test
Before submitting
pre-commit run -a
command without errorsDid you have fun?
Make sure you had fun coding 🙃