mzweilin commented 1 year ago

What does this PR do?

This PR adds support to rectangle patch adversary.

Type of change

Please check all relevant options.

[ ] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[x] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[x] The title is self-explanatory and the description concisely explains the PR
[x] My PR does only one thing, instead of bundling different changes together
[ ] I list all the breaking changes introduced by this pull request
[x] I have commented my code
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have run pre-commit hooks with pre-commit run -a command without errors

Make sure you had fun coding 🙃

dxoigmn commented 1 year ago

It would really be nice if this wasn't dependent upon modality dispatch.

mzweilin commented 8 months ago

Close in favor of #241