dxoigmn commented 1 year ago

What does this PR do?

This adds a gradient monitor callback so that one can make monitor the norm of different gradients.

Type of change

Please check all relevant options.

[x] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[ ] No tests

Before submitting

[x] The title is self-explanatory and the description concisely explains the PR
[x] My PR does only one thing, instead of bundling different changes together
[x] I list all the breaking changes introduced by this pull request
[x] I have commented my code
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

mzweilin commented 1 year ago

Do you have an example? I tried to run this command, but I didn't see gradient logs in Tensorboard.

CUDA_VISIBLE_DEVICES=0 \
python -m mart \
experiment=CIFAR10_CNN_Adv \
fit=false \
trainer=gpu \
+trainer.limit_test_batches=1 \
+callbacks@model.modules.input_adv_test.callbacks=gradient_monitor \
+model.modules.input_adv_test.callbacks.gradient_monitor.frequency=1

Update: patch and example in #164

dxoigmn commented 1 year ago

There are no parameters in an Adversary ;) This is why I think it's better to modify the state_dict rather than playing tricks by hiding parameters in lists.