IntelLabs / MART

Modular Adversarial Robustness Toolkit
BSD 3-Clause "New" or "Revised" License
16 stars 0 forks source link

Update torch requirement from ~=1.13.1 to ~=2.0.1 #148

Open dependabot[bot] opened 1 year ago

dependabot[bot] commented 1 year ago

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
mzweilin commented 1 year ago

We should also upgrade to the latest template: https://github.com/ashleve/lightning-hydra-template/compare/v1.4.0...v2.0.2

Notable changes

mzweilin commented 1 year ago

Changes in pytorch-lightning ~= 1.6.5 -> lightning ~= 2.0.2.

mzweilin commented 1 year ago

lightning 2.0.2 depends on torchmetrics<2.0 and >=0.7.0.

However, we want to keep torchmetrics == 0.6.0 because mAP is super slow in later versions.

I hope torchmetrics will change the backend of mAP soon in the upcoming release.

Changes in torchmetrics == 0.6.0 -> torchmetrics == 0.11.4

dxoigmn commented 1 year ago

The reason we used torchmetrics == 0.6.0 is because MeanAveragePrecision is super slow in newer versions. It looks like they're finally going to revert back to the original implementation that uses the COCOapi: https://github.com/Lightning-AI/torchmetrics/issues/1024.

dxoigmn commented 1 year ago

Should this be closed @mzweilin?