IntelLabs / MART

Modular Adversarial Robustness Toolkit
BSD 3-Clause "New" or "Revised" License
16 stars 0 forks source link

Better Composer #154

Open dxoigmn opened 1 year ago

dxoigmn commented 1 year ago

What does this PR do?

Type of change

Please check all relevant options.

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

Before submitting

Did you have fun?

Make sure you had fun coding 🙃

dxoigmn commented 1 year ago

@mzweilin: i could use your help on thinking about how to compose composers. the problem i'm seeing is that some composer want to modify the input and others want to modify the perturbation. right now, composers only returned a new input so there's no way to propagate changes to the perturbation.

some changes to perturbation are independent of the input, but others are not (e.g., resizing the perturbation to the size of the input). it's worth keeping in mind the use case in #132.

dxoigmn commented 1 year ago

We can also just not worry about composition of composers.