SequentialDict uses CallWith to manage how to call a underlying nn.Module and handle that nn.Module's output. All of this is handled at instantiation time. This PR adds the ability to override this functionality at execution time by adding those same special args to CallWith.forward.
Type of change
Please check all relevant options.
[x] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
What does this PR do?
SequentialDict
usesCallWith
to manage how to call a underlyingnn.Module
and handle thatnn.Module
's output. All of this is handled at instantiation time. This PR adds the ability to override this functionality at execution time by adding those same special args toCallWith.forward
.Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
pytest
CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16
reports 70% (21 sec/epoch).CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2
reports 70% (14 sec/epoch).Before submitting
pre-commit run -a
command without errorsDid you have fun?
Make sure you had fun coding 🙃