Closed mzweilin closed 7 months ago
The current flake8 6.0.0 we use in pre-commit requires space after : in strings when running in Python 3.12. So we upgrade to the latest 7.0.0.
:
flake8 7.0.0 does not allow comparing type(obj), so we changed it to isinstance(obj, *).
type(obj)
isinstance(obj, *)
Please check all relevant options.
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
pytest
CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16
CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2
pre-commit run -a
Make sure you had fun coding đŸ™ƒ
What does this PR do?
The current flake8 6.0.0 we use in pre-commit requires space after
:
in strings when running in Python 3.12. So we upgrade to the latest 7.0.0.flake8 7.0.0 does not allow comparing
type(obj)
, so we changed it toisinstance(obj, *)
.Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
pytest
CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16
reports 70% (21 sec/epoch).CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2
reports 70% (14 sec/epoch).Before submitting
pre-commit run -a
command without errorsDid you have fun?
Make sure you had fun coding đŸ™ƒ