Closed lkuper closed 7 years ago
One of the ECOOP artifact reviewers pointed out that https://github.com/IntelLabs/ParallelAccelerator.jl/blob/5e7ece3bb450399d0c6ef1e11f92a4f339d00f0c/deps/build.sh#L72 hard-codes icpc, not the compiler found on line 42, which could be g++. This would cause BLAS detection to fail even if it's present when using GCC.
icpc
g++
Knowing that the "right" way to fix this would be to use something like autoconf or CMake to detect dependencies and deal with different environments, would it be a sensible band-aid fix to just use $CC here?
$CC
(cc @ehsantn)
https://github.com/IntelLabs/ParallelAccelerator.jl/commit/ae4f7ee695abe50074aa6567c3e7ea90bcd13877 addresses this.
lkuper
commented
7 years ago
One of the ECOOP artifact reviewers pointed out that https://github.com/IntelLabs/ParallelAccelerator.jl/blob/5e7ece3bb450399d0c6ef1e11f92a4f339d00f0c/deps/build.sh#L72 hard-codes
icpc, not the compiler found on line 42, which could beg++. This would cause BLAS detection to fail even if it's present when using GCC.Knowing that the "right" way to fix this would be to use something like autoconf or CMake to detect dependencies and deal with different environments, would it be a sensible band-aid fix to just use
$CChere?(cc @ehsantn)