IntelLabs / ParallelAccelerator.jl

The ParallelAccelerator package, part of the High Performance Scripting project at Intel Labs
BSD 2-Clause "Simplified" License
294 stars 32 forks source link

Drop unnecessary packages from REQUIRE #99

Closed blakejohnson closed 8 years ago

blakejohnson commented 8 years ago

Several packages are listed in REQUIRE that are only used in the examples, and thus could be dropped. I didn't do an exhaustive search, but at minimum it looks like you could remove: Images, ImageMagick, and Winston.

lkuper commented 8 years ago

Yeah, we did this so that our examples would run right out of the box, for instance on Travis. But there are other ways to handle that.

blakejohnson commented 8 years ago

Well, if it is for testing, you can drop a REQUIRE file inside your test/ directory and get that for free.

KristofferC commented 8 years ago

https://github.com/IntelLabs/ParallelAccelerator.jl/issues/10#issuecomment-152515072

:)

ehsantn commented 8 years ago

Let's drop the dependencies. They are constant source of trouble, especially because they need binary libraries.

lkuper commented 8 years ago

Yeah, I now disagree with my past self in this comment. The developers should have the test/REQUIRE packages installed already, and on Travis everything has to get installed every time anyway. I'll just put the dependencies in test/REQUIRE.