search

IntelLabs / RiverTrail

An API for data parallelism in JavaScript
Other
748 stars 71 forks source link

liquid-resize demo crashes Firefox #47

Closed lkuper closed 9 years ago

lkuper commented 9 years ago

The liquid-resize demo consistently crashes Firefox on all the platforms I've tried (Windows 7, Windows 8, Mac, Linux), and with both the old (FF 25) and new (FF 35) versions of the extension. I don't think this is a regression caused by the new extension, because it happens with the old one, too. We should figure out why this is happening and fix it.

lkuper commented 9 years ago

I submitted a crash report: https://crash-stats.mozilla.com/report/index/40dd0fbe-4744-491a-ac10-5ffc22150126 . @jsreeram, do you think any useful info is to be gained from this?

jsreeram commented 9 years ago

I have pushed a patch that fixes this. @lkuper, please let me know if it works for you. If it doesn't, please let me know.

lkuper commented 9 years ago

Thanks! Yes, this fixes the crash for me on Mac and Linux. I'm guessing you've already tested Windows.

BTW, I noticed one of your edits to the tutorial sneaked into 65c1f4e. I'm making a bunch of tutorial changes in another branch that I'll push soon.