Closed y0ast closed 3 years ago
Hello @y0ast ,
Thank you for your contribution to the repo. These bugs were in the list to be fixed along with other fixes. Thanks for the PR, merging the commit.
Thanks for merging! Are you able to share the list of other fixes you are planning? (So I can avoid those bugs in my own work building on your codebase).
I have pushed the commits (09b8d0a and 6a370d9) to the repo just before merging your PR. If you checkout from the head of main branch, these fixes should be already in.
Hello,
I think there might be a few problems in your model definitions.
In particular:
resnet_flipout.py
andresnet_variational.py
you only sum thekl
of the lastblock
insideself.layerN
resnet_flipout_large.py
andresnet_variational_large.py
you check foris None
while you probably wantis not None
or actually no check at all since it can't beNone
in any reasonable setting. Also thestr(layer)
check is odd since it contains aBasicBlock
orBottleNeck
object (you're looping over annn.Sequential
ofblock
s). In fact in this code that string check is very likely superfluous (didn't test this, but I did include it in this PR as example)I hope you can confirm and perhaps fix these issues, which will help me (and maybe others) in building on your nice codebase :)