IntelLabs / bayesian-torch

A library for Bayesian neural network layers and uncertainty estimation in Deep Learning extending the core of PyTorch
BSD 3-Clause "New" or "Revised" License
483 stars 67 forks source link

Fix KL computation #2

Closed y0ast closed 2 years ago

y0ast commented 2 years ago

Hello,

I think there might be a few problems in your model definitions.

In particular:

I hope you can confirm and perhaps fix these issues, which will help me (and maybe others) in building on your nice codebase :)

ranganathkrishnan commented 2 years ago

Hello @y0ast ,

Thank you for your contribution to the repo. These bugs were in the list to be fixed along with other fixes. Thanks for the PR, merging the commit.

y0ast commented 2 years ago

Thanks for merging! Are you able to share the list of other fixes you are planning? (So I can avoid those bugs in my own work building on your codebase).

ranganathkrishnan commented 2 years ago

I have pushed the commits (09b8d0a and 6a370d9) to the repo just before merging your PR. If you checkout from the head of main branch, these fixes should be already in.