search

IntelLabs / coach

Reinforcement Learning Coach by Intel AI Lab enables easy experimentation with state of the art Reinforcement Learning algorithms
https://intellabs.github.io/coach/
Apache License 2.0
2.32k stars 459 forks source link

tests: added new setup configuration #211

Closed anabwan closed 5 years ago

anabwan commented 5 years ago
anabwan commented 5 years ago

Thanks Scott, I've fixed your comments, please see my comments

scttl commented 5 years ago

Looks like your most recent push introduced some import errors for get_marker. Can you fix the unit test and integration test

anabwan commented 5 years ago

how can we downgrade pytest to version: 4.0.2 instead of 4.2.0 see here: https://github.com/pytest-dev/pytest-cov/issues/252

scttl commented 5 years ago

how can we downgrade pytest to version: 4.0.2 instead of 4.2.0 see here: pytest-dev/pytest-cov#252

Relying on deprecated functions/old pytest versions is not the right solve here. Instead we should update the code per: https://docs.pytest.org/en/latest/mark.html#updating-code i.e. utilize get_closest_marker or iterate as appropriate.

anabwan commented 5 years ago

how can we downgrade pytest to version: 4.0.2 instead of 4.2.0 see here: pytest-dev/pytest-cov#252

Relying on deprecated functions/old pytest versions is not the right solve here. Instead we should update the code per: https://docs.pytest.org/en/latest/mark.html#updating-code i.e. utilize get_closest_marker or iterate as appropriate.

fixed