search

IntelLabs / coach

Reinforcement Learning Coach by Intel AI Lab enables easy experimentation with state of the art Reinforcement Learning algorithms
https://intellabs.github.io/coach/
Apache License 2.0
2.32k stars 459 forks source link

Mujoco tests are not running in CI #272

Closed gal-leibovich closed 5 years ago

gal-leibovich commented 5 years ago

golden_test_mujoco does not actually run mujoco’s golden tests. It seems that only BitFlip presets are run as part of the test. e.g. https://circleci.com/gh/NervanaSystems/coach/2057?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

This is although the circleci’s config.yaml is filtering for either BitFlip or Mujoco https://github.com/NervanaSystems/coach/blob/master/.circleci/config.yml#L241

anabwan commented 5 years ago

I can run both, bitflip and mujoco.. but since the name of the marker is "golden_test_mujoco", I think we should keep the mujoco test only, I'm thinking of adding new golden for Bitflip, what you think ?

gal-leibovich commented 5 years ago

I don't think that BitFlip requires a category of its own. We can move it to the gym test category if you think it is helpful.

anabwan commented 5 years ago

fixed https://github.com/NervanaSystems/coach/pull/274

anabwan commented 5 years ago

I see the bug... this is what I got: Ayoob: {'args': ['export GOLDEN_PRESETS=CartPole or BitFlip && make ' 'golden_tests_without_docker'],

I'll fix it, will update soon

anabwan commented 5 years ago

fixed https://github.com/NervanaSystems/coach/pull/284 please review