search

IntelLabs / coach

Reinforcement Learning Coach by Intel AI Lab enables easy experimentation with state of the art Reinforcement Learning algorithms
https://intellabs.github.io/coach/
Apache License 2.0
2.32k stars 460 forks source link

Unnecessary futures dependency #324

Closed timokau closed 5 years ago

timokau commented 5 years ago

Coach depends on futures:

https://github.com/NervanaSystems/coach/blob/30c2b2fc4586d1bf6b50e1b6f2c2a5c04acf2947/requirements.txt#L12

But also requires at least python 3.5. The futures documentation says:

This is a backport of the concurrent.futures standard library module to Python 2.

It should not be installed on Python 3, although there should be no harm in doing so, as the standard library takes precedence over third party libraries.