The /sml-lib/Makefile do not work with the newest version of MLton

IntelLabs / flrc

Haskell Research Compiler

Other

816 stars 37 forks source link

The /sml-lib/Makefile do not work with the newest version of MLton #2

Closed Neuromancer42 closed 7 years ago

Neuromancer42 commented 7 years ago

I tried to build flrc with MLton 20130715, but it failed at first, shows Error: /home/neuromancer/Projects/FLRC/flrc/sml-lib/mlton/basic/sources.mlb 15.7.

I found this in the Line 3 of /sml-lib/Makefile, which writes: MLTON_LIBDIR=$(abspath $(dir $(MLTON_BIN))/../lib/mlton/sml)

But when I check the actual structure in my local MLton directory structure, I think it should be: MLTON_LIBDIR=$(abspath $(dir $(MLTON_BIN))/../lib/sml).

The change worked and I build it successfully after this.

ninegua commented 7 years ago

Which distro are you using? For me, both older mlton 20100608 and mlton 20130715 install to the following directory structure (on 3 different distros, Debian, Redhat, NixOS):

${PREFIX}/bin
${PREFIX}/lib/mlton/
${PREFIX}/share/man/man1/

So changing it to lib/sml would certainly break things.

ninegua commented 7 years ago

Maybe this is a better way to get the lib directory:

mlton -verbose 2|grep 'lib dir'

It prints lib dir: /usr/lib/mlton on my Debian. What is the output you get?

Neuromancer42 commented 7 years ago

It's /home/neuromancer/Applications/mlton/lib.

Neuromancer42 commented 7 years ago

Oh, I see... It's because I am using mlton without installation... That's my fault, and please close it.

ninegua commented 7 years ago

Ok, no problem.