IntelLabs / kafl.fuzzer

kAFL Fuzzer
Other
33 stars 16 forks source link

Proposal: CI/CD to enforce best practises #14

Open Wenzel opened 2 years ago

Wenzel commented 2 years ago

Issue

kafl.fuzzer has no CI/CD mechanism in place, and the code currently merged into master has not garantee or code quality enforcements whatsoever.

Proposal

Deploy a CI to perform basic code quality enforcements:

Also, this should come with helpers on the developer side to verify that their code meet the CI requirements. I'm thinking about Makefile specific developer targets:

il-steffen commented 2 years ago

Yes please. Why not make format and make check?

For Black, lets see what the changes are. A quick test shows mostly unchanged code, but several instances of uselessly turning a a too long logger/print into 3 lines:

logger(
"still too long line"
)

I'd rather have those parts fixed than blindly reformatting them.