Open Wenzel opened 2 years ago
Yes please. Why not make format
and make check
?
For Black
, lets see what the changes are. A quick test shows mostly unchanged code, but several instances of uselessly turning a a too long logger/print into 3 lines:
logger(
"still too long line"
)
I'd rather have those parts fixed than blindly reformatting them.
Issue
kafl.fuzzer
has no CI/CD mechanism in place, and the code currently merged into master has not garantee or code quality enforcements whatsoever.Proposal
Deploy a CI to perform basic code quality enforcements:
Black
andisort
flake8
Bandit
, integrated into flake8 viaflake8-bandit
vermin
Also, this should come with helpers on the developer side to verify that their code meet the CI requirements. I'm thinking about
Makefile
specific developer targets:make fmt
make lint
make pre_commit
(do all the checks)