Wip/pr 2457 testing2 - Githubissues

IntelLabs / numba

NumPy aware dynamic Python compiler using LLVM

http://numba.pydata.org/

BSD 2-Clause "Simplified" License

12 stars 2 forks source link

Wip/pr 2457 testing2 #37

Closed stuartarchibald closed 7 years ago

stuartarchibald commented 7 years ago

@DrTodd13 More test cases below. I'll comment on the ones I think need discussion/fixing.

Also, in offline discussion, @seibert suggested swapping the name standard_indexing for direct_access, which might be a more suitable name given types such as tuples could be index and need to be accessed directly?

stuartarchibald commented 7 years ago

@DrTodd13 thanks for the fixes on this, I think it's just https://github.com/IntelLabs/numba/pull/37#discussion_r145656737 that needs addressing?

On the back of this:

the Numba team needs to have a bit of a think about standard_indexing and interaction with types that support indexing and guvectorize in general.
I need to write tests for neighbourhood.
the core implementation needs code review, functional review should be near done.

sklam commented 7 years ago

The changes in tests is making the line https://github.com/IntelLabs/numba/blob/fa9d69dcd1e6f26466b3deae80fccb83d6d17aab/numba/stencilparfor.py#L90 never reached by the tests. The base branch reaches that line though. I have yet to determine what changes is responsible.

stuartarchibald commented 7 years ago

Closing this PR, PR #39 updates.