search

IntelLabs / pmgd

Persistent Memory Graph Database
MIT License
43 stars 9 forks source link

Persistence #2

Closed vishakha041 closed 6 years ago

vishakha041 commented 6 years ago

I have fixed some of our persistence story in the code and added options with msync picking some code from Philip's old branch for the OS stuff. Let's review this ASAP since our experiments and VDMS correctness in non-PM world is getting affected.

And I timed our run_all.sh tests on a broadwell system. Here are the timings in seconds: Done: 111.824376704: Msync on commit Done: 1.995483082: NoMsync Done: 211.634081555: AlwaysMsync

philiplantz commented 6 years ago

In GraphImpl::GraphInit::GraphInit:

    #ifdef PM
        // check cpuid to see that the instruction $(PMFLUSH) is supported
    #endif
vishakha041 commented 6 years ago

I have addressed most of these comments and will create a new pull request.