search

IntelLabs / pmgd

Persistent Memory Graph Database
MIT License
43 stars 9 forks source link

Persistence #3

Closed vishakha041 closed 6 years ago

vishakha041 commented 6 years ago

These are the updates based on review comments. The last two commits will be merged with the second commit. So a total of 3 commits when we merge this branch.

My non-scientific evaluation: For our run_all.sh timing when running the unit tests (time in seconds).

Without a map MsyncOnCommit - 114.555903399 NoMsync - 1.764198926 AlwaysMsync - 209.394729821

With a map MsyncOnCommit - 106.721010523 NoMsync - 1.843715119 AlwaysMsync - 206.935488722

just clflush and sfence: 2.263883903

luisremis commented 6 years ago

It looks good to me, I asked Philip to explain a couple of things to me, and he is going over the updates.

You can only squash ALL the commits without new approval. If we approve and then you squash some of the commits, we need to approve again for the merge.

vishakha041 commented 6 years ago

It should now be good to go. I removed default options from everywhere and just changed the tests. The names should be consistent too.