Add filter for edges for get_neighbors

IntelLabs / pmgd

Persistent Memory Graph Database

MIT License

43 stars 9 forks source link

Add filter for edges for get_neighbors #41

Closed luisremis closed 5 years ago

vishakha041 commented 5 years ago

Probably we should add tests of this feature to neighbortest. Also we should update the API spec.

And a test at PMGD level for the change please. I know VDMS is testing it. But PMGD is still independent of VDMS. Until that changes, it makes sense to keep it standalone.

philiplantz commented 5 years ago

Probably we should add tests of this feature to neighbortest. Also we should update the API spec.

And a test at PMGD level for the change please. I know VDMS is testing it. But PMGD is still independent of VDMS. Until that changes, it makes sense to keep it standalone.

Yes, I agree, that's what I meant to say: Add a test to the PMGD neighbortest and update the PMGD API spec.

luisremis commented 5 years ago

tests added, should be good to go.

luisremis commented 5 years ago

all comments addressed.

luisremis commented 5 years ago

@vishakha041 If no more comments here, I will go ahead with the merge tomorrow.