search

IntelLabs / vdms

VDMS: Your Favorite Visual Data Management System
MIT License
84 stars 31 forks source link

Add FindFrames command #110

Closed mahircg closed 5 years ago

mahircg commented 5 years ago

This patch introduces 'FindFrames' command, that searches for the given video name and returns a list of frames from the video if it is found.

Currently, FindFrame command relies on OpenCV's frame iteration capabilities. Thus, the entire video is loaded into memory to be decoded. In future, the video loading and decoding should be done only on the requested frame interval.

Signed-off-by: mahircg mahircan.guel@intel.com

vishakha041 commented 5 years ago

I'll look at this once we close the other PR. I believe this is based off of that one.

luisremis commented 5 years ago

@vishakha041, these are independent, as you can see following the commits. So you can go ahead and review it.

luisremis commented 5 years ago

All comments addressed. Good to go for me!

mahircg commented 5 years ago

I've just did an interactive rebase on all three patches to sign them off. All the changes look good to me.

luisremis commented 5 years ago

Created a separate commit for fixing a bug in Video command response.

Should be good to go.