search

IntelLabs / vdms

VDMS: Your Favorite Visual Data Management System
MIT License
84 stars 31 forks source link

Change default Image format #111

Closed luisremis closed 5 years ago

luisremis commented 5 years ago

TDB format only performs better with very large images, and it is usually not the first choice for users, forcing them to explicitly change for format for every insertion or getting error messages. It is better to just go with JPG as the default until we start seeing more use cases showing the benefits of the format.

vishakha041 commented 5 years ago

Only small concern here, shouldn't png be default since it is lossless? Or more like, set it to whatever the original is??

luisremis commented 5 years ago

sounds good, we can switch to use the original format or the image. Fixed and all tests passing, wiki updated.

As a future enhancement (#73 ), if the user does not specify a change of format nor operations, we need to write the image directly.