Closed ifadams closed 1 month ago
Do you think it is necessary to also clear the cache when the index is deleted in
This is a concern of mine longer term, but it doesn't look like the "delete" is actually externally connected at the moment. i.e. I dont see any VDMS level logic that lets us fully remove an index. At most, with some gymnastics we might be able to remove the descriptor set reference from the graph database, but even thats a little murky.
@s-gobriel do you know if there's an example or call we can check to see if a client can actually trigger a delete of either the index or the referencing PMGD node?
Target CPP Coverage: 64.4418% Source CPP Coverage: 64.3906%
Target Python Coverage: 98% Source Python Coverage: 98%
Target CPP Coverage: 64.4418% Source CPP Coverage: 64.3906%
Target Python Coverage: 98% Source Python Coverage: 98%
Target CPP Coverage: 64.4418% Source CPP Coverage: 64.3906%
Target Python Coverage: 98% Source Python Coverage: 98%
Target CPP Coverage: 64.4418% Source CPP Coverage: 64.3906%
Target Python Coverage: 98% Source Python Coverage: 98%
Target CPP Coverage: 64.4418% Source CPP Coverage: 64.3906%
Target Python Coverage: 98% Source Python Coverage: 98%
Target CPP Coverage: 64.4418% Source CPP Coverage: 64.3906%
Target Python Coverage: 98% Source Python Coverage: 98%
Hey Folks,
This is a draft PR for the descriptor set path caching.
Currently, to the best of my knowledge, we can't actually delete a descriptor set after creation so this is a fairly minimal change.
It relies on the fact that a descriptor set path, as well as its dimensionality, will never change after creation. This lets us bypass the database query after the initial caching of the path and dimensions for a named set.