search

IntelLabs / vdms

VDMS: Your Favorite Visual Data Management System
MIT License
84 stars 31 forks source link

Add flip/rotate #41

Closed luisremis closed 5 years ago

luisremis commented 5 years ago

Adding very simple operations that some users requested for VDMS. I hope this PR can be used as reference for contributors on how to add new operations.

vishakha041 commented 5 years ago

I think it starts becoming beneficial after a certain number of elements. For now this might be ok. Best would be to do some of these conversions at client library end

From: Luis [mailto:notifications@github.com] Sent: Monday, October 22, 2018 2:43 PM To: IntelLabs/vdms vdms@noreply.github.com Cc: Gupta, Vishakha S vishakha.s.gupta@intel.com; Review requested review_requested@noreply.github.com Subject: Re: [IntelLabs/vdms] Add flip/rotate (#41)

@luisremis commented on this pull request.

In src/ImageCommand.cchttps://github.com/IntelLabs/vdms/pull/41#discussion_r227148920:

@@ -63,6 +63,13 @@ void ImageCommand::enqueue_operations(VCL::Image& img, const Json::Value& ops)

                     get_value<int>(op, "width"),

                     get_value<int>(op, "height") ));

     }

good idea, we can have a string table here.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/IntelLabs/vdms/pull/41#discussion_r227148920, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXWdAhQkAmW06CE7PFw8A5QqwHMgDfoFks5unjvLgaJpZM4XdTLM.