search

IntelLabs / vdms

VDMS: Your Favorite Visual Data Management System
MIT License
84 stars 31 forks source link

Feature sort descending #53

Closed luisremis closed 5 years ago

luisremis commented 5 years ago

Solve #52

luisremis commented 5 years ago

I like what you propose @philiplantz. For some reason I have a memory that we cannot do that. Let me try it harder.

vishakha041 commented 5 years ago

I like the option Philip has mentioned. Otherwise option 1 from Luis. It will break backward compatibility but will open the way for allowing sort on multiple keys and so on in the near future.

luisremis commented 5 years ago

Sorting multiple keys is independent for of the having a sort block or not. I will go with option 2 to avoid braking compatibility for now, and change the keywords following Philip suggestion which is much nicer.

luisremis commented 5 years ago

Good news, after trying many different schema configurations, it is indeed possible to have: "sort" : "" and "sort" : { "key" : "", "order" : "descending" } Will push this, since this looks nice and avoid braking backward compatibility.

Now I wonder what was the memory both @philiplantz and I have, and if we can make some other checks better. But at least now we are sure we can.

vishakha041 commented 5 years ago

For multiple keys we will need a sort block but never mind for now. Its good that the other option worked. Cool.

mwahle commented 5 years ago

When can we have this in the master branch? Or even released?

luisremis commented 5 years ago

Our "develop" branch is like a master branch. We only commit to master with releases. In any case, we are working on a new release that will have this change (and everything pushed into the "develop" branch) in the next 10-20 days.