IntelLabs / vdms

VDMS: Your Favorite Visual Data Management System
MIT License
84 stars 31 forks source link

Bounding Box API #55

Closed crstrong closed 5 years ago

crstrong commented 5 years ago

Support for the Bounding Box API for rectangles, along with tests (both in C++ and Python).

luisremis commented 5 years ago

Something off with the tests on my setup:

[----------] 1 test from FindImage [ RUN ] FindImage.simpleFind [Exception] ObjectEmpty at src/ImageData.cc:70 db/images/png/4c328cc66771034.png could not be read, object is empty tests/json_queries.cc:138: Failure Value of: "0" Expected: json_response[0]["FindImage"]["status"].asString() Which is: "-1" [ FAILED ] FindImage.simpleFind (10 ms) [----------] 1 test from FindImage (10 ms total)

[----------] 1 test from UpdateEntity [ RUN ] UpdateEntity.simpleAddUpdate [ OK ] UpdateEntity.simpleAddUpdate (21 ms) [----------] 1 test from UpdateEntity (21 ms total)

[----------] 1 test from QueryHandler [ RUN ] QueryHandler.AddAndFind [ OK ] QueryHandler.AddAndFind (36 ms) [----------] 1 test from QueryHandler (36 ms total)

[----------] 5 tests from BoundingBox [ RUN ] BoundingBox.simpleAdd [ OK ] BoundingBox.simpleAdd (15 ms) [ RUN ] BoundingBox.addAndFind [ OK ] BoundingBox.addAndFind (13 ms) [ RUN ] BoundingBox.addWithImage [ OK ] BoundingBox.addWithImage (15 ms) [ RUN ] BoundingBox.addAndFindCoordinates [ OK ] BoundingBox.addAndFindCoordinates (13 ms) [ RUN ] BoundingBox.findBBWithBlob [Exception] ObjectEmpty at src/ImageData.cc:158 Image object is empty [Exception] ObjectEmpty at src/ImageData.cc:158 Image object is empty [ OK ] BoundingBox.findBBWithBlob (12 ms) [----------] 5 tests from BoundingBox (68 ms total)

crstrong commented 5 years ago

You may have to add a db/images/png folder to the test folder. I believe I needed to.

luisremis commented 5 years ago

cool, will make a note to add that on the scripts as part of the PR.

vishakha041 commented 5 years ago

Should I review this PR or wait for updates from what Luis has requested?

crstrong commented 5 years ago

I believe all of his comments have been addressed, so please do review the PR