search

IntelLabs / vdms

VDMS: Your Favorite Visual Data Management System
MIT License
84 stars 31 forks source link

Bug fixes #95

Closed vishakha041 closed 5 years ago

vishakha041 commented 5 years ago

Fixes to some reported issues like error on empty results

luisremis commented 5 years ago

Also, it would be great to have python tests for this kind of bug fixes, even if similar to the unit tests you have for c++

vishakha041 commented 5 years ago

Do you want me to merge this fix before the VCL changes or after?

luisremis commented 5 years ago

Looks good to go! Conflicts should be straight forward to fix. Either adding and extra commit for the conflict fix or amending the last commit (with the tests cases) should be fine.

vishakha041 commented 5 years ago

Should be good to merge now. Take a look. Passes on my system with the new test hierarchy.