IntelPython / dpctl

Python SYCL bindings and SYCL-based Python Array API library
https://intelpython.github.io/dpctl/
Apache License 2.0
97 stars 29 forks source link

More docstring edits #1636

Closed oleksandr-pavlyk closed 2 months ago

oleksandr-pavlyk commented 3 months ago

Docstring edits for dpctl.memory and dpctl.utils namespaces.

github-actions[bot] commented 3 months ago

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:

coveralls commented 3 months ago

Coverage Status

coverage: 88.049% (-0.03%) from 88.076% when pulling e3bc17f4723046cf002ebc9540de4823f1466965 on more-docstring-edits into ca59c3dc3ff3a15e8f24008dc3cf974724572f60 on master.

github-actions[bot] commented 3 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_202 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 3 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_203 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 3 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_203 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 3 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_204 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_206 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_206 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_215 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_217 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_218 ran successfully. Passed: 870 Failed: 8 Skipped: 92

ndgrigorian commented 2 months ago

@oleksandr-pavlyk https://github.com/IntelPython/dpctl/blob/f8b27aa2facb24e646ddc884f734a9ab95a88039/dpctl/_sycl_device.pyx#L927 Maybe these references to nd_range should be changed to sycl::nd_range<N>.

oleksandr-pavlyk commented 2 months ago

@oleksandr-pavlyk

https://github.com/IntelPython/dpctl/blob/f8b27aa2facb24e646ddc884f734a9ab95a88039/dpctl/_sycl_device.pyx#L927

Maybe these references to nd_range should be changed to sycl::nd_range<N>.

Good idea! Pushed changes as suggested.

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_219 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_220 ran successfully. Passed: 870 Failed: 8 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_222 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_224 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_225 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_226 ran successfully. Passed: 869 Failed: 9 Skipped: 92

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_228 ran successfully. Passed: 869 Failed: 9 Skipped: 92

oleksandr-pavlyk commented 2 months ago

Thank you @ndgrigorian and @antonwolfy for the review. Merging this batch, and will open a new PR should more changes be needed.

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_229 ran successfully. Passed: 869 Failed: 9 Skipped: 92