Implements `out` keyword for `where` and reductions and `order` keyword for `where`

ndgrigorian commented 2 months ago

This pull request proposes building on the set of functions supporting the out keyword in dpctl. Specifically, this pull request implements this keyword in all reductions (e.g., sum, max, argmax) and where. This paves the way for statistical functions to support the keyword, and may make some function calls more efficient.

This pull request also implements the order keyword in where, now defaulting to order="K" behavior rather than order="A".

[X] Have you provided a meaningful PR description?
[X] Have you added a test, reproducer or referred to an issue with a reproducer?
[X] Have you tested your changes locally for CPU and GPU devices?
[X] Have you made sure that new changes do not introduce compiler warnings?
[ ] Have you checked performance impact of proposed changes?
[ ] If this PR is a work in progress, are you opening the PR as a draft?

github-actions[bot] commented 2 months ago

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_243 ran successfully. Passed: 870 Failed: 8 Skipped: 92

coveralls commented 2 months ago

coverage: 88.177% (+0.1%) from 88.049% when pulling 16b631f79cdd1ae4e65a4f916dabda1947acf718 on where-reductions-out-kw into a8acdf0660f660f2ab27067ebe9a576c7e403f24 on master.

oleksandr-pavlyk commented 2 months ago

Overall, good change, thanks @ndgrigorian ! Love the increase in coverage

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_308 ran successfully. Passed: 870 Failed: 8 Skipped: 92

IntelPython / dpctl

Implements `out` keyword for `where` and reductions and `order` keyword for `where` #1643