IntelPython / dpctl

Python SYCL bindings and SYCL-based Python Array API library
https://intelpython.github.io/dpctl/
Apache License 2.0
99 stars 29 forks source link

Avoid sycl::queue copying in libtensor #1645

Closed oleksandr-pavlyk closed 5 months ago

oleksandr-pavlyk commented 5 months ago

Changed signatures functions to take sycl::queue argument by reference, not by value.

Since sycl::queue contains a shared pointer inside, copying it involves operating atomic variable, and hence should be avoided if possible.

github-actions[bot] commented 5 months ago

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:

github-actions[bot] commented 5 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_296 ran successfully. Passed: 870 Failed: 8 Skipped: 92

coveralls commented 5 months ago

Coverage Status

coverage: 88.049%. remained the same when pulling ffe13ea4ea021d61afb237755a672762e4192c1b on change-signatures-to-use-queue-ref into 182aedea00b5a5e81bb0f4d81983387f5094b7cf on master.