IntelPython / dpctl

Python SYCL bindings and SYCL-based Python Array API library
https://intelpython.github.io/dpctl/
Apache License 2.0
97 stars 29 forks source link

Type promotion for `indices` arrays and casting `vals` in integer indexing #1647

Closed ndgrigorian closed 2 months ago

ndgrigorian commented 2 months ago

This pull request proposes resolutions to #1360, #1382, and #1482 by changing the behavior of advanced indexing and indexing functions.

Additionally, this PR implements changes to take, put, and generalized advanced integer indexing which handle cases where empty axes are being indexed.

github-actions[bot] commented 2 months ago

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_305 ran successfully. Passed: 870 Failed: 8 Skipped: 92

coveralls commented 2 months ago

Coverage Status

coverage: 88.21% (+0.03%) from 88.177% when pulling 6b3b09939673f646449431558f5172b6279b5658 on integer-indexing-casting into f5c6610b62244a24f98e03ce9f97cc5a9433879f on master.

github-actions[bot] commented 2 months ago

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_306 ran successfully. Passed: 870 Failed: 8 Skipped: 92