Closed ndgrigorian closed 1 month ago
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:
This looks uncontroversial enough for me.
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_352 ran successfully. Passed: 888 Failed: 17 Skipped: 91
@vtavana confirmed that dpctl test suite was unaffected by this change, I will go ahead and merge it
Internal CI failures also unrelated
This PR proposes a change to
clip
,matmul
, and theBinaryElementwiseFunc
class which makesC
the default contiguity of outputs whenorder="K"
and the input arrays must be cast.This fixes a minor discrepancy where when multiple input arrays are both C- and F-contiguous and need to be cast, the output defaulted to F-contiguous instead of C-contiguous, creating unusual edge cases where type promotion (and therefore the selected device) became relevant to the output array's order, which should not be the case.
For example
The selected device's type promotion graph contains
float64
, leading to F-contiguous outputs.after this change: