Closed ndgrigorian closed 1 month ago
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_29 ran successfully. Passed: 890 Failed: 11 Skipped: 91
It might be a good idea to scan the code base for remaining uses of
std
namespace transcendental functions and replace those one by one too
I agree. I'll do this as a separate PR, but I think it's a good idea too.
I have opened gh-1701 for build break with LLVM SYCL compiler, it is unrelated to changes in this PR.
When compiled for CUDA,
std::rint
would incorrectly round values halfway between two integers towards 0 (i.e.,1.5 -> 1.
). The array API specification requires that these values be rounded to the nearest even integer instead.To resolve this,
std::rint
has been replaced withsycl::rint
, which does not rely on the current floating-point rounding mode (see SYCL specification).As was pointed out at the time of implementation the floating-point rounding mode can vary between devices.