Improve exception raised by `broadcast_arrays` with no arguments

IntelPython / dpctl

Python SYCL bindings and SYCL-based Python Array API library

https://intelpython.github.io/dpctl/

Apache License 2.0

97 stars 29 forks source link

Improve exception raised by `broadcast_arrays` with no arguments #1720

Closed ndgrigorian closed 5 days ago

ndgrigorian commented 6 days ago

This PR improves the message of the ValueError raised by broadcast_arrays when called with no arguments.

Closes #1718

[X] Have you provided a meaningful PR description?
[X] Have you added a test, reproducer or referred to an issue with a reproducer?
[X] Have you tested your changes locally for CPU and GPU devices?
[X] Have you made sure that new changes do not introduce compiler warnings?
[ ] Have you checked performance impact of proposed changes?
[ ] If this PR is a work in progress, are you opening the PR as a draft?

github-actions[bot] commented 6 days ago

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:

github-actions[bot] commented 6 days ago

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_80 ran successfully. Passed: 894 Failed: 15 Skipped: 105

coveralls commented 6 days ago

coverage: 87.902% (-0.2%) from 88.057% when pulling 21e1958b67ba67259a8f156b09717e11893c673c on fix-broadcast-arrays-no-args into 26d34f565d36572b3207cd1e969312eae4eabacc on master.

ndgrigorian commented 5 days ago

Test failures in linux CI and coverage dip are unrelated to this PR. Test failure appears to be related to the release of 2024.2.0 (as it wasn't present prior).

I will go ahead and merge this and continue to investigate the CI in a separate PR, so that this can move to the dev milestone.