Technical debt - Githubissues

IntelPython / dpctl

Python SYCL bindings and SYCL-based Python Array API library

https://intelpython.github.io/dpctl/

Apache License 2.0

102 stars 30 forks source link

Technical debt #1852

Closed oleksandr-pavlyk closed 1 month ago

oleksandr-pavlyk commented 1 month ago

This PR

adds missing #include <stdexcept> to files that use std::runtime_error exception
adds missing #include <new> to files that use std::bad_alloc exception
functions that submit kernels which are compiled by means of calling sycl::get_kernel_bundle<sycl::bundle_state::executable> now use cgh.use_kernel_bundle(kb) to avoid recompiling that kernel.

[x] Have you provided a meaningful PR description?
[ ] Have you added a test, reproducer or referred to an issue with a reproducer?
[ ] Have you tested your changes locally for CPU and GPU devices?
[ ] Have you made sure that new changes do not introduce compiler warnings?
[ ] Have you checked performance impact of proposed changes?
[ ] Have you added documentation for your changes, if necessary?
[ ] Have you added your changes to the changelog?
[ ] If this PR is a work in progress, are you opening the PR as a draft?

github-actions[bot] commented 1 month ago

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:

github-actions[bot] commented 1 month ago

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_99 ran successfully. Passed: 895 Failed: 0 Skipped: 119

github-actions[bot] commented 1 month ago

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_104 ran successfully. Passed: 894 Failed: 1 Skipped: 119

coveralls commented 1 month ago

coverage: 87.907%. remained the same when pulling c04db57793388a6f10870c750658a1ba542fd816 on technical-debt into 9085854c5abbfa6b1b6810a3b6ced7f254c36743 on master.

ndgrigorian commented 1 month ago

@oleksandr-pavlyk Seems dpctl4pybind11.hpp includes exception instead of stdexcept, kernels/elementwise_functions/common.hpp doesn't include stdexcept either. Those were the only cases I found left (outside of the examples).

github-actions[bot] commented 1 month ago

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_105 ran successfully. Passed: 895 Failed: 0 Skipped: 119

oleksandr-pavlyk commented 1 month ago

@ndgrigorian Thank you for catching the omissions. I have pushed two commits with fixes.

github-actions[bot] commented 1 month ago

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_107 ran successfully. Passed: 895 Failed: 0 Skipped: 119