Refactor code - Githubissues

IntelPython / scikit-learn_bench

scikit-learn_bench benchmarks various implementations of machine learning algorithms across data analytics frameworks. It currently support the scikit-learn, DAAL4PY, cuML, and XGBoost frameworks for commonly used machine learning algorithms.

Apache License 2.0

113 stars 69 forks source link

Refactor code #97

Closed LyndonFan closed 3 years ago

LyndonFan commented 3 years ago

Addresses most issues in #95

Fixed 2 instances of unnecessary else
Fixed 2 instances of using range(len(...))
Fixed 1 instance of code complexity by removing unnecessary "is not None" check
Fixed 1 instance of code security by using requests.get instead of urllib.request.urlretrieve

There is still 1 instance of code complexity issue remaining. I have performed some minor refactoring, but it's still too complex according to codefactor.io.

LyndonFan commented 3 years ago

The new code has passed all the checks. Would it be possible to get a review?