search

IntelPython / sdc

Numba extension for compiling Pandas data frames, Intel® Scalable Dataframe Compiler
https://intelpython.github.io/sdc-doc/
BSD 2-Clause "Simplified" License
646 stars 62 forks source link

Impl Series.skew() #813

Closed Rubtsowa closed 4 years ago

Rubtsowa commented 4 years ago
name nthreads type size median min max compile boxing
Series.skew 1 Python 100000000 5.041041 4.553035 6.009044 NaN NaN
    SDC 100000000 1.082 1.066 1.091 0.205984 0.00001
Series.skew 4 Python 100000000 6.681195 4.275043 14.061077 NaN NaN
    SDC 100000000 1.07 0.99 1.135 0.329002 0.00001
pep8speaks commented 4 years ago

Hello @Rubtsowa! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-04-24 16:12:26 UTC
AlexanderKalistratov commented 4 years ago

@Rubtsowa looks good. Could you please remeasure performance?

Rubtsowa commented 4 years ago
name nthreads type size median min max compile boxing
Series.skew 1 Python 100000000 9.940206 5.385197 19.73827 NaN NaN
    SDC 100000000 0.989 0.711 1.241 0.167002 0
Series.skew 4 SDC 100000000 0.731 0.719 0.847 0.105322 0.000417
Rubtsowa commented 4 years ago
name nthreads type size median min max compile boxing
Series.skew 1 Python 100000000 6.973869 4.221513 9.153432 NaN NaN
    SDC 100000000 0.597 0.595 0.604 0.12701 0.00008
Series.skew 4 SDC 100000000 0.199 0.197 0.208 0.134013 0.000026
Rubtsowa commented 4 years ago
name nthreads type size median min max compile boxing
Series.skew(skipna=False) 1 Python 100000000 3.396047 3.068078 4.135047 NaN NaN
    SDC 100000000 0.165 0.165 0.171 0.200001 0.000002
  4 SDC 100000000 0.08 0.078 0.09 0.211993 0.000009