search

IntelPython / sdc

Numba extension for compiling Pandas data frames, Intel® Scalable Dataframe Compiler
https://intelpython.github.io/sdc-doc/
BSD 2-Clause "Simplified" License
645 stars 61 forks source link

Remove hardcoded dependencies from install instruction #969

Closed kozlov-alexey closed 3 years ago

kozlov-alexey commented 3 years ago

Motivation: installation instruction is often updated at the same time when SDC moves to new version of dependencies, and while building SDC from source works, installing from pre-built binaries might fail since package is uploaded to intel/label/beta only after all validation checks.

Fixes #968

kozlov-alexey commented 3 years ago

Need to verify that pip is working too..

Vyacheslav-Smirnov commented 3 years ago

As I remember, these changes "pyarrow=2.0.0 pandas=1.2.0" were added to fix issue when old sdc version is installed instead of fresh because old sdc required less changes in environment then new... If now latest version is installed using updated commands - it is fine. Regarding pip - maybe we need to remove these instructions while SDC new wheel packages is ready, because they can install only old version which I think not up-to-date.

pep8speaks commented 3 years ago

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-18 11:55:15 UTC