search

IntelPython / sdc

Numba extension for compiling Pandas data frames, Intel® Scalable Dataframe Compiler
https://intelpython.github.io/sdc-doc/
BSD 2-Clause "Simplified" License
645 stars 61 forks source link

Fixes pack of failed tests #974

Closed kozlov-alexey closed 3 years ago

kozlov-alexey commented 3 years ago

Motivation: as title.

pep8speaks commented 3 years ago

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-05-06 17:37:37 UTC
Hardcode84 commented 3 years ago

Skipping floordiv test due to diff behavior in Stock vs Intel numpy

This is probably a real bug either on our side or on intel Numpy/mkl side. Better to report this to mkl team

kozlov-alexey commented 3 years ago

Skipping floordiv test due to diff behavior in Stock vs Intel numpy

This is probably a real bug either on our side or on intel Numpy/mkl side. Better to report this to mkl team

I created SAT-4111 for tracking it. Also it seems like these unexpected successes of this test in azure pipeline were caused by move from numpy=1.19 to numpy=1.20, where (see https://github.com/numpy/numpy/pull/16161) floordiv behavior was changed.

kozlov-alexey commented 3 years ago

Merging this to unblock CI (fails in python 3.8 checks are investigated by Infra team).